Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problems found when running hugging face text summariztion model on large input. #929

Merged
merged 8 commits into from
Aug 13, 2023
Merged

Fix problems found when running hugging face text summariztion model on large input. #929

merged 8 commits into from
Aug 13, 2023

Conversation

xzdandy
Copy link
Collaborator

@xzdandy xzdandy commented Aug 12, 2023

  1. Pass batch_mem_size correctly to storage engines
  2. Fix hugging face crash when the number of input token is large then the limit.

👋 Thanks for submitting a Pull Request to EvaDB!

🙌 We want to make contributing to EvaDB as easy and transparent as possible. Here are a few tips to get you started:

  • 🔍 Search existing EvaDB PRs to see if a similar PR already exists.
  • 🔗 Link this PR to a EvaDB issue to help us understand what bug fix or feature is being implemented.
  • 📈 Provide before and after profiling results to help us quantify the improvement your PR provides (if applicable).

👉 Please see our ✅ Contributing Guide for more details.

@xzdandy xzdandy marked this pull request as ready for review August 13, 2023 04:24
@xzdandy xzdandy requested review from gaurav274 and jiashenC August 13, 2023 04:25
@xzdandy xzdandy merged commit dbad313 into master Aug 13, 2023
@xzdandy xzdandy deleted the fix_hugging_face branch August 13, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaurav274 gaurav274 gaurav274 approved these changes

@jiashenC jiashenC Awaiting requested review from jiashenC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xzdandy @gaurav274